PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/kite9/diagram/adl/Arrow.java

Violation Line
It is a good practice to call super() in a constructor 24 - 25

org/kite9/diagram/adl/Context.java

Violation Line
It is a good practice to call super() in a constructor 41 - 42

org/kite9/diagram/adl/Diagram.java

Violation Line
It is a good practice to call super() in a constructor 26 - 27

org/kite9/diagram/adl/Glyph.java

Violation Line
It is a good practice to call super() in a constructor 48 - 49

org/kite9/diagram/adl/Key.java

Violation Line
Use explicit scoping instead of the default package private level 18
Use explicit scoping instead of the default package private level 20
Use explicit scoping instead of the default package private level 30
It is a good practice to call super() in a constructor 40 - 44
Use explicit scoping instead of the default package private level 54 - 55

org/kite9/diagram/adl/KeyHelper.java

Violation Line
Use explicit scoping instead of the default package private level 24
Use explicit scoping instead of the default package private level 26
A method should have only one exit point, and that should be the last statement in the method 32
Use explicit scoping instead of the default package private level 56
Use explicit scoping instead of the default package private level 57
Avoid unnecessary constructors - the compiler will generate these for you 59 - 60
A method should have only one exit point, and that should be the last statement in the method 69
A method should have only one exit point, and that should be the last statement in the method 76
A method should have only one exit point, and that should be the last statement in the method 84
A method should have only one exit point, and that should be the last statement in the method 104
A method should have only one exit point, and that should be the last statement in the method 117
A method should have only one exit point, and that should be the last statement in the method 126
A method should have only one exit point, and that should be the last statement in the method 130

org/kite9/diagram/adl/Link.java

Violation Line
It is a good practice to call super() in a constructor 26 - 27

org/kite9/diagram/adl/Symbol.java

Violation Line
Use explicit scoping instead of the default package private level 12 - 13
Use explicit scoping instead of the default package private level 19 - 20
Use explicit scoping instead of the default package private level 22 - 23
A method should have only one exit point, and that should be the last statement in the method 30
A method should have only one exit point, and that should be the last statement in the method 33
A method should have only one exit point, and that should be the last statement in the method 71

org/kite9/diagram/adl/TextLine.java

Violation Line
Use explicit scoping instead of the default package private level 19
Use explicit scoping instead of the default package private level 25
It is a good practice to call super() in a constructor 27 - 29
It is a good practice to call super() in a constructor 31 - 32
Use explicit scoping instead of the default package private level 55 - 56

org/kite9/diagram/builders/ClassBuilder.java

Violation Line
These nested if statements could be combined 38 - 40
Found 'DU'-anomaly for variable 'cl' (lines '164'-'176'). 164 - 176
Found 'DU'-anomaly for variable 'cl' (lines '164'-'176'). 164 - 176
Found 'DU'-anomaly for variable 'cl' (lines '164'-'176'). 164 - 176
Found 'DU'-anomaly for variable 'cl' (lines '252'-'268'). 252 - 268
Found 'DU'-anomaly for variable 'cl' (lines '252'-'268'). 252 - 268
Found 'DU'-anomaly for variable 'cl' (lines '252'-'268'). 252 - 268

org/kite9/diagram/builders/DiagramBuilder.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 102
A method should have only one exit point, and that should be the last statement in the method 107
A method should have only one exit point, and that should be the last statement in the method 112
A method should have only one exit point, and that should be the last statement in the method 114
Found 'DU'-anomaly for variable 'within' (lines '132'-'144'). 132 - 144
Found 'DU'-anomaly for variable 'within' (lines '147'-'159'). 147 - 159
Found 'DU'-anomaly for variable 'within' (lines '162'-'174'). 162 - 174
A method should have only one exit point, and that should be the last statement in the method 228
Found 'DU'-anomaly for variable 'objectEndStyle' (lines '249'-'274'). 249 - 274
Found 'DU'-anomaly for variable 'alias' (lines '253'-'274'). 253 - 274

org/kite9/diagram/builders/Filter.java

Violation Line
Avoid modifiers which are implied by the context 11

org/kite9/diagram/builders/Format.java

Violation Line
Avoid modifiers which are implied by the context 5

org/kite9/diagram/builders/IdHelper.java

Violation Line
Use explicit scoping instead of the default package private level 18
A method should have only one exit point, and that should be the last statement in the method 22
A method should have only one exit point, and that should be the last statement in the method 24
A method should have only one exit point, and that should be the last statement in the method 26
A method should have only one exit point, and that should be the last statement in the method 28
A method should have only one exit point, and that should be the last statement in the method 30
A method should have only one exit point, and that should be the last statement in the method 32

org/kite9/diagram/builders/JavaModifier.java

Violation Line
Use explicit scoping instead of the default package private level 7

org/kite9/diagram/builders/MethodBuilder.java

Violation Line
Found 'DU'-anomaly for variable 'cl' (lines '67'-'80'). 67 - 80
Found 'DU'-anomaly for variable 'cl' (lines '86'-'99'). 86 - 99
Found 'DU'-anomaly for variable 'cl' (lines '105'-'117'). 105 - 117

org/kite9/diagram/builders/PackageBuilder.java

Violation Line
Found 'DU'-anomaly for variable 'cl' (lines '35'-'47'). 35 - 47

org/kite9/diagram/builders/Relationship.java

Violation Line
Use explicit scoping instead of the default package private level 29
A method should have only one exit point, and that should be the last statement in the method 65

org/kite9/diagram/builders/SubjectBinding.java

Violation Line
Use explicit scoping instead of the default package private level 23
Use explicit scoping instead of the default package private level 25
Avoid using final local variables, turn them into fields 41
Found 'DD'-anomaly for variable 'result' (lines '42'-'43'). 42 - 43
A method should have only one exit point, and that should be the last statement in the method 51
A method should have only one exit point, and that should be the last statement in the method 53
A method should have only one exit point, and that should be the last statement in the method 55
A method should have only one exit point, and that should be the last statement in the method 60
A method should have only one exit point, and that should be the last statement in the method 62
A method should have only one exit point, and that should be the last statement in the method 65
A method should have only one exit point, and that should be the last statement in the method 67

org/kite9/diagram/builders/Tie.java

Violation Line
Use explicit scoping instead of the default package private level 23
Use explicit scoping instead of the default package private level 24
Use explicit scoping instead of the default package private level 25
Avoid using final local variables, turn them into fields 29
Found 'DD'-anomaly for variable 'result' (lines '30'-'31'). 30 - 31
A method should have only one exit point, and that should be the last statement in the method 38
A method should have only one exit point, and that should be the last statement in the method 40
A method should have only one exit point, and that should be the last statement in the method 42
A method should have only one exit point, and that should be the last statement in the method 46
A method should have only one exit point, and that should be the last statement in the method 48
A method should have only one exit point, and that should be the last statement in the method 51
A method should have only one exit point, and that should be the last statement in the method 53

org/kite9/diagram/builders/ValueHelper.java

Violation Line
Use explicit scoping instead of the default package private level 14 - 17
Use explicit scoping instead of the default package private level 22
Avoid modifiers which are implied by the context 26 - 30
Found 'DD'-anomaly for variable 'cont' (lines '79'-'81'). 79 - 81
Found 'DU'-anomaly for variable 'args' (lines '92'-'106'). 92 - 106
A method should have only one exit point, and that should be the last statement in the method 100
A method should have only one exit point, and that should be the last statement in the method 118
A method should have only one exit point, and that should be the last statement in the method 122
Avoid unnecessary constructors - the compiler will generate these for you 130 - 132

org/kite9/diagram/position/CostedDimension.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 60
A method should have only one exit point, and that should be the last statement in the method 62
A method should have only one exit point, and that should be the last statement in the method 65
A method should have only one exit point, and that should be the last statement in the method 67
A method should have only one exit point, and that should be the last statement in the method 71
A method should have only one exit point, and that should be the last statement in the method 73
A method should have only one exit point, and that should be the last statement in the method 77
A method should have only one exit point, and that should be the last statement in the method 79

org/kite9/diagram/position/Dimension2D.java

Violation Line
Use explicit scoping instead of the default package private level 54
Use explicit scoping instead of the default package private level 55
Ensure you override both equals() and hashCode() 58
A method should have only one exit point, and that should be the last statement in the method 61
It is a good practice to call super() in a constructor 66 - 68
It is a good practice to call super() in a constructor 70 - 74

org/kite9/diagram/position/Direction.java

Violation Line
Found 'DD'-anomaly for variable 'ord' (lines '12'-'13'). 12 - 13
Found 'DD'-anomaly for variable 'ord' (lines '19'-'20'). 19 - 20
A method should have only one exit point, and that should be the last statement in the method 27
Found 'DD'-anomaly for variable 'ord' (lines '28'-'29'). 28 - 29

org/kite9/diagram/position/HPos.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 11

org/kite9/diagram/position/RectangleRenderingInformation.java

Violation Line
Use explicit scoping instead of the default package private level 16
Use explicit scoping instead of the default package private level 17
Use explicit scoping instead of the default package private level 19
Use explicit scoping instead of the default package private level 20
Avoid unnecessary constructors - the compiler will generate these for you 23 - 24

org/kite9/diagram/position/RouteRenderingInformation.java

Violation Line
Avoid unnecessary constructors - the compiler will generate these for you 15 - 16
Found 'DD'-anomaly for variable 'x' (lines '70'-'72'). 70 - 72
Found 'DD'-anomaly for variable 'y' (lines '70'-'73'). 70 - 73
Found 'DD'-anomaly for variable 'x' (lines '80'-'82'). 80 - 82
Found 'DD'-anomaly for variable 'y' (lines '80'-'83'). 80 - 83

org/kite9/diagram/position/VPos.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 15

org/kite9/diagram/primitives/AbstractBiDirectional.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 57
A method should have only one exit point, and that should be the last statement in the method 74
A method should have only one exit point, and that should be the last statement in the method 77

org/kite9/diagram/primitives/AbstractConnectedContained.java

Violation Line
Use explicit scoping instead of the default package private level 40 - 41
A method should have only one exit point, and that should be the last statement in the method 61
A method should have only one exit point, and that should be the last statement in the method 63
Ensure you override both equals() and hashCode() 74
A method should have only one exit point, and that should be the last statement in the method 100

org/kite9/diagram/primitives/AbstractConnection.java

Violation Line
It is a good practice to call super() in a constructor 20 - 21
A method should have only one exit point, and that should be the last statement in the method 71

org/kite9/diagram/primitives/AbstractContainer.java

Violation Line
It is a good practice to call super() in a constructor 41 - 42

org/kite9/diagram/primitives/AbstractLabel.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 28

org/kite9/diagram/primitives/BiDirectional.java

Violation Line
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 17
Avoid modifiers which are implied by the context 19
Avoid modifiers which are implied by the context 21
Avoid modifiers which are implied by the context 28
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 42
Avoid modifiers which are implied by the context 44

org/kite9/diagram/primitives/CompositionalDiagramElement.java

Violation Line
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 20

org/kite9/diagram/primitives/Connection.java

Violation Line
Avoid modifiers which are implied by the context 14
Avoid modifiers which are implied by the context 19
Avoid modifiers which are implied by the context 24
Avoid modifiers which are implied by the context 29

org/kite9/diagram/primitives/Contained.java

Violation Line
Avoid modifiers which are implied by the context 10
Avoid modifiers which are implied by the context 12

org/kite9/diagram/primitives/Container.java

Violation Line
Avoid modifiers which are implied by the context 19
Avoid modifiers which are implied by the context 28
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 36

org/kite9/diagram/primitives/DiagramElement.java

Violation Line
Avoid modifiers which are implied by the context 10

org/kite9/diagram/primitives/IdentifiableDiagramElement.java

Violation Line
Avoid modifiers which are implied by the context 21
Avoid modifiers which are implied by the context 23

org/kite9/diagram/visitors/DiagramElementVisitor.java

Violation Line
Use explicit scoping instead of the default package private level 22

org/kite9/diagram/visitors/VisitorAction.java

Violation Line
Avoid modifiers which are implied by the context 7

org/kite9/framework/alias/AbstractAliaser.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 28
A method should have only one exit point, and that should be the last statement in the method 32
A method should have only one exit point, and that should be the last statement in the method 44
A method should have only one exit point, and that should be the last statement in the method 53
A method should have only one exit point, and that should be the last statement in the method 62
A method should have only one exit point, and that should be the last statement in the method 69
A method should have only one exit point, and that should be the last statement in the method 80
A method should have only one exit point, and that should be the last statement in the method 84
A method should have only one exit point, and that should be the last statement in the method 103
A method should have only one exit point, and that should be the last statement in the method 115
A method should have only one exit point, and that should be the last statement in the method 117
A method should have only one exit point, and that should be the last statement in the method 119
A method should have only one exit point, and that should be the last statement in the method 121
A method should have only one exit point, and that should be the last statement in the method 123
A method should have only one exit point, and that should be the last statement in the method 125
A method should have only one exit point, and that should be the last statement in the method 127
A method should have only one exit point, and that should be the last statement in the method 145
A method should have only one exit point, and that should be the last statement in the method 147
A method should have only one exit point, and that should be the last statement in the method 149
A method should have only one exit point, and that should be the last statement in the method 151
A method should have only one exit point, and that should be the last statement in the method 153
A method should have only one exit point, and that should be the last statement in the method 155

org/kite9/framework/alias/AliasEnabled.java

Violation Line
Avoid modifiers which are implied by the context 11

org/kite9/framework/alias/Aliaser.java

Violation Line
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 17
Avoid modifiers which are implied by the context 19
Avoid modifiers which are implied by the context 21
Avoid modifiers which are implied by the context 23
Avoid modifiers which are implied by the context 25
Avoid modifiers which are implied by the context 27
Avoid modifiers which are implied by the context 29
Avoid modifiers which are implied by the context 31

org/kite9/framework/alias/PropertyAliaser.java

Violation Line
Use explicit scoping instead of the default package private level 13
Avoid unnecessary constructors - the compiler will generate these for you 16 - 17
It is a good practice to call super() in a constructor 16 - 17

org/kite9/framework/classloading/OverrideJarClassLoader.java

Violation Line
Use explicit scoping instead of the default package private level 26
Use explicit scoping instead of the default package private level 27
A method should have only one exit point, and that should be the last statement in the method 32
This statement may have some unnecessary parentheses 43
A method should have only one exit point, and that should be the last statement in the method 43
Avoid empty catch blocks 45 - 46
This statement may have some unnecessary parentheses 57
A method should have only one exit point, and that should be the last statement in the method 57
Avoid empty catch blocks 59 - 60
Use explicit scoping instead of the default package private level 80
Use explicit scoping instead of the default package private level 82
Use explicit scoping instead of the default package private level 83
Use explicit scoping instead of the default package private level 84
Found 'DU'-anomaly for variable 'theFile' (lines '116'-'124'). 116 - 124
Found 'DD'-anomaly for variable 'theFile' (lines '116'-'116'). 116
Found 'DU'-anomaly for variable 'start' (lines '131'-'145'). 131 - 145
Found 'DU'-anomaly for variable 'length' (lines '132'-'145'). 132 - 145

org/kite9/framework/common/FileDiff.java

Violation Line
Found 'DU'-anomaly for variable 'fisA' (lines '24'-'39'). 24 - 39
Found 'DU'-anomaly for variable 'fisB' (lines '25'-'39'). 25 - 39
Found 'DD'-anomaly for variable 'found' (lines '77'-'82'). 77 - 82
Found 'DU'-anomaly for variable 'aLines' (lines '99'-'116'). 99 - 116

org/kite9/framework/common/RepositoryHelp.java

Violation Line
Found 'DD'-anomaly for variable 'f' (lines '13'-'20'). 13 - 20
A method should have only one exit point, and that should be the last statement in the method 27
Found 'DU'-anomaly for variable 'buffer' (lines '35'-'48'). 35 - 48
Avoid empty catch blocks 45 - 46
Found 'DU'-anomaly for variable 'buffer' (lines '52'-'65'). 52 - 65
Avoid empty catch blocks 62 - 63

org/kite9/framework/common/StackHelp.java

Violation Line
These nested if statements could be combined 25 - 27
Found 'DD'-anomaly for variable 'cl' (lines '36'-'38'). 36 - 38
Avoid empty catch blocks 39 - 40
A method should have only one exit point, and that should be the last statement in the method 47

org/kite9/framework/common/TestingHelp.java

Violation Line
Found 'DD'-anomaly for variable 'directory' (lines '153'-'154'). 153 - 154
A method should have only one exit point, and that should be the last statement in the method 156

org/kite9/framework/logging/Kite9Log.java

Violation Line
Use explicit scoping instead of the default package private level 15

org/kite9/framework/logging/Logable.java

Violation Line
Avoid modifiers which are implied by the context 5
Avoid modifiers which are implied by the context 7

org/kite9/framework/logging/Table.java

Violation Line
Use explicit scoping instead of the default package private level 14
Use explicit scoping instead of the default package private level 16
Found 'DU'-anomaly for variable 'col' (lines '52'-'61'). 52 - 61
Found 'DU'-anomaly for variable 'col' (lines '59'-'61'). 59 - 61
Found 'DU'-anomaly for variable 'colno' (lines '65'-'78'). 65 - 78
Found 'DD'-anomaly for variable 'colno' (lines '65'-'65'). 65
Found 'DD'-anomaly for variable 'colno' (lines '73'-'65'). 73 - 65
Found 'DU'-anomaly for variable 'colno' (lines '73'-'78'). 73 - 78

org/kite9/framework/model/MemberHandle.java

Violation Line
Assigning an Object to null is a code smell. Consider refactoring. 45
Avoid using final local variables, turn them into fields 92
Found 'DD'-anomaly for variable 'result' (lines '93'-'94'). 93 - 94
A method should have only one exit point, and that should be the last statement in the method 104
A method should have only one exit point, and that should be the last statement in the method 106
A method should have only one exit point, and that should be the last statement in the method 108
A method should have only one exit point, and that should be the last statement in the method 112
A method should have only one exit point, and that should be the last statement in the method 114
A method should have only one exit point, and that should be the last statement in the method 117
A method should have only one exit point, and that should be the last statement in the method 119
A method should have only one exit point, and that should be the last statement in the method 122
A method should have only one exit point, and that should be the last statement in the method 124
A method should have only one exit point, and that should be the last statement in the method 127
A method should have only one exit point, and that should be the last statement in the method 129
A method should have only one exit point, and that should be the last statement in the method 174
Found 'DD'-anomaly for variable 'out' (lines '177'-'179'). 177 - 179
Found 'DD'-anomaly for variable 'out' (lines '179'-'179'). 179
This statement may have some unnecessary parentheses 219
A method should have only one exit point, and that should be the last statement in the method 219
A method should have only one exit point, and that should be the last statement in the method 221
A method should have only one exit point, and that should be the last statement in the method 223

org/kite9/framework/model/ProjectModel.java

Violation Line
Avoid modifiers which are implied by the context 17
Avoid modifiers which are implied by the context 22
Avoid modifiers which are implied by the context 27
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 58

org/kite9/framework/model/ProjectModelImpl.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 50

org/kite9/framework/model/Type.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 231
A method should have only one exit point, and that should be the last statement in the method 233
A method should have only one exit point, and that should be the last statement in the method 235
A method should have only one exit point, and that should be the last statement in the method 237
A method should have only one exit point, and that should be the last statement in the method 239
A method should have only one exit point, and that should be the last statement in the method 241
A method should have only one exit point, and that should be the last statement in the method 243
A method should have only one exit point, and that should be the last statement in the method 245
A method should have only one exit point, and that should be the last statement in the method 247
Found 'DD'-anomaly for variable 'off' (lines '264'-'279'). 264 - 279
Avoid empty while statements 271 - 272
Found 'DD'-anomaly for variable 'args' (lines '278'-'282'). 278 - 282
Found 'DU'-anomaly for variable 'size' (lines '280'-'287'). 280 - 287
Found 'DD'-anomaly for variable 'types' (lines '299'-'301'). 299 - 301
Found 'DD'-anomaly for variable 'types' (lines '301'-'301'). 301
A method should have only one exit point, and that should be the last statement in the method 342
A method should have only one exit point, and that should be the last statement in the method 344
A method should have only one exit point, and that should be the last statement in the method 346
A method should have only one exit point, and that should be the last statement in the method 348
A method should have only one exit point, and that should be the last statement in the method 350
A method should have only one exit point, and that should be the last statement in the method 352
A method should have only one exit point, and that should be the last statement in the method 354
A method should have only one exit point, and that should be the last statement in the method 356
A method should have only one exit point, and that should be the last statement in the method 358
A method should have only one exit point, and that should be the last statement in the method 370
A method should have only one exit point, and that should be the last statement in the method 430
A method should have only one exit point, and that should be the last statement in the method 432
A method should have only one exit point, and that should be the last statement in the method 434
A method should have only one exit point, and that should be the last statement in the method 436
A method should have only one exit point, and that should be the last statement in the method 438
A method should have only one exit point, and that should be the last statement in the method 440
A method should have only one exit point, and that should be the last statement in the method 442
A method should have only one exit point, and that should be the last statement in the method 444
A method should have only one exit point, and that should be the last statement in the method 446
A method should have only one exit point, and that should be the last statement in the method 452
A method should have only one exit point, and that should be the last statement in the method 519
A method should have only one exit point, and that should be the last statement in the method 522
A method should have only one exit point, and that should be the last statement in the method 525
A method should have only one exit point, and that should be the last statement in the method 528
A method should have only one exit point, and that should be the last statement in the method 531
A method should have only one exit point, and that should be the last statement in the method 534
A method should have only one exit point, and that should be the last statement in the method 537
A method should have only one exit point, and that should be the last statement in the method 540
A method should have only one exit point, and that should be the last statement in the method 543
Found 'DU'-anomaly for variable 'd' (lines '625'-'665'). 625 - 665
A method should have only one exit point, and that should be the last statement in the method 649
A method should have only one exit point, and that should be the last statement in the method 694
A method should have only one exit point, and that should be the last statement in the method 697
A method should have only one exit point, and that should be the last statement in the method 701
A method should have only one exit point, and that should be the last statement in the method 705
Found 'DD'-anomaly for variable 'j' (lines '707'-'707'). 707
Found 'DU'-anomaly for variable 'j' (lines '707'-'714'). 707 - 714
A method should have only one exit point, and that should be the last statement in the method 709
Found 'DD'-anomaly for variable 'hc' (lines '722'-'725'). 722 - 725

org/kite9/framework/repository/BasicFileRepository.java

Violation Line
Found 'DU'-anomaly for variable 'matches' (lines '47'-'60'). 47 - 60
Found 'DU'-anomaly for variable 'matches' (lines '47'-'60'). 47 - 60
This statement may have some unnecessary parentheses 50

org/kite9/framework/repository/Repository.java

Violation Line
Avoid modifiers which are implied by the context 20
Avoid modifiers which are implied by the context 22
Avoid modifiers which are implied by the context 24

org/kite9/framework/server/ItemServer.java

Violation Line
Avoid modifiers which are implied by the context 16
Avoid modifiers which are implied by the context 18

org/kite9/framework/server/WorkItem.java

Violation Line
Avoid modifiers which are implied by the context 9
Avoid modifiers which are implied by the context 11
Avoid modifiers which are implied by the context 13
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 17